Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7936 Refactor calendar test to handle multiple selectors for form fields. #3530

Merged
merged 6 commits into from
Oct 22, 2024
Merged

BC-7936 Refactor calendar test to handle multiple selectors for form fields. #3530

merged 6 commits into from
Oct 22, 2024

Conversation

UzaeirKhan
Copy link
Contributor

@UzaeirKhan UzaeirKhan commented Oct 17, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7936

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@UzaeirKhan UzaeirKhan marked this pull request as ready for review October 17, 2024 10:46
hoeppner-dataport
hoeppner-dataport previously requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes that were caused by incorrect formater.
Besides that -it's only suggestions.

static/scripts/calendar.js Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
@UzaeirKhan UzaeirKhan enabled auto-merge (squash) October 18, 2024 09:45
muratmerdoglu-dp
muratmerdoglu-dp requested changes Oct 22, 2024
View reviewed changes
static/scripts/calendar.js Outdated Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
static/scripts/calendar.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@UzaeirKhan UzaeirKhan disabled auto-merge October 22, 2024 11:45
@UzaeirKhan UzaeirKhan enabled auto-merge (squash) October 22, 2024 11:45
@UzaeirKhan UzaeirKhan merged commit f057394 into main Oct 22, 2024
67 checks passed
@UzaeirKhan UzaeirKhan deleted the BC-7936-refactor-calendar-test branch October 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratmerdoglu-dp muratmerdoglu-dp muratmerdoglu-dp approved these changes

@NFriedo NFriedo Awaiting requested review from NFriedo

@hoeppner-dataport hoeppner-dataport Awaiting requested review from hoeppner-dataport

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UzaeirKhan @muratmerdoglu-dp @hoeppner-dataport